Trivial bug fixes to record EcalSampleMask

[argiro]

Trivial fix of typo-style bugs. Those bugs did not affect the few runs in which this code was actually used. Just nice to have it fixed for the posterity.
While at it, I turned a few couts into LogError

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24963/6934

[cmsbuild]

A new Pull Request was created by @argiro for master.

It involves the following packages:

CondFormats/EcalObjects

@tocheng, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[tocheng]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31208/console Started: 2018/10/22 23:24

[cmsbuild]

+1
Tested at: e3863d0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24963/31208/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24963/31208/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2994843
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2994644
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[tocheng]

+1

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@argiro how frequent is the error condition triggering the LogError? Is this level of verbosity appropriate, as you are doing a cleaning?

[argiro]

On 23 Oct 2018, at 22:32, Fabio Cossutti ***@***.***> wrote: @argiro how frequent is the error condition triggering the LogError? Is this level of verbosity appropriate, as you are doing a cleaning?

well it will never happen unless the object in the DB has the wrong length. So never in production. And the masking itself is something that we haven't used in ages.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fabiocos]

+1