Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure DtCalib AlCaReco for heavy Ion 2018 #25004

Merged
merged 2 commits into from
Oct 26, 2018

Conversation

tocheng
Copy link
Contributor

@tocheng tocheng commented Oct 25, 2018

Greetings,

The PR is to add DtCalibHI into the AlCaReco stream.
The DtCalib in the AlCaReco stream is replaced by sequence in DtCalibHI using the pp_on_AA_2018 era.
Also the DtCalibOutput is replaced by the DtCalibHIOut using the pp_on_AA_2018 era.

The configuration is checked using
python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunExpressProcessing.py --scenario ppEra_Run2_2018_pp_on_AA --global-tag 103X_dataRun2_Express_v1 --lfn /store/whatever --fevt --dqmio --alcareco DtCalib

After changing pickle to python config,
one can see that the DtCalib path and output is replaced by the path and output in DtCalibHI

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @tocheng (Tongguang) for master.

It involves the following packages:

CalibMuon/DTCalibration

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor Author

tocheng commented Oct 25, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31275/console Started: 2018/10/25 21:54


OutALCARECODtCalibHI = copy.deepcopy(OutALCARECODtCalib_noDrop)
OutALCARECODtCalibHI.outputCommands.insert(0, "drop *")
OutALCARECODtCalibHI.outputCommands.append("keep *_hiSelectedVertex_*_*")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tocheng I am wondering is this event product available with thepp_on_AA_2018 era customisations?
@mandrenguyen

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmusich Thanks for pointing it out. I checked the configuration generated using DP config with pp_on_AA scenario, the hiSelectedVertex is not in the sequence. It should be the module in heavyIon typed reconstruction. I can remove it after the test is done.

@mmusich
Copy link
Contributor

mmusich commented Oct 25, 2018

Hello @fabiocos, @slava77,
while this PR runs fine in the last IB of 10.3.X using:

python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunExpressProcessing.py --scenario ppEra_Run2_2018_pp_on_AA --global-tag 103X_dataRun2_Express_v1 --lfn /store/t0streamer/Data/HIExpress/000/325/112/run325112_ls0013_streamHIExpress_StorageManager.dat --fevt --dqmio --alcareco DtCalib

and then changing the event source with:

process.source = cms.Source("NewEventStreamFileReader"

while doing the same in 10.4.X I notice I incur in this error:

----- Begin Fatal Exception 25-Oct-2018 22:56:57 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found: 
hiConformalPixelTracks after hiConformalPixelTracksPhase1Filter [path reconstruction_step], hiConformalPixelTracksPhase1Filter after pixelFitterByConformalMappingAndLine [path reconstruction_step], pixelFitterByConformalMappingAndLine after hiConformalPixelTracksPhase1HitQuadrupletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitQuadrupletsCA after hiConformalPixelTracksPhase1HitDoubletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitDoubletsCA after hiConformalPixelTracksPhase1SeedLayers [path reconstruction_step], hiConformalPixelTracksPhase1SeedLayers after hiConformalPixelTracksPhase1TrackingRegions [path reconstruction_step], hiConformalPixelTracksPhase1TrackingRegions after hiClusterCompatibility [path reconstruction_step], hiClusterCompatibility after hiCentrality [path reconstruction_step], hiCentrality consumes hiConformalPixelTracks
 Running in the threaded framework would lead to indeterminate results.
 Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------

the same error is also obtained in a vanilla CMSSW_10_4_X_2018-10-25-1100.
Is there any substantial difference between the tip of 10.3.X and the tip of 10.4.X that can cause this?

@mandrenguyen
Copy link
Contributor

mandrenguyen commented Oct 25, 2018 via email

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #25004 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@tocheng
Copy link
Contributor Author

tocheng commented Oct 25, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31279/console Started: 2018/10/26 00:58

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25004/31279/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2994843
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2994645
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@tocheng
Copy link
Contributor Author

tocheng commented Oct 26, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@tocheng did you verify it works? If I use your recipe

python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunExpressProcessing.py --scenario ppEra_Run2_2018_pp_on_AA --global-tag 103X_dataRun2_Express_v1 --lfn /store/whatever --fevt --dqmio --alcareco DtCalib

and replace the input with

process.source = cms.Source("NewEventStreamFileReader",
fileNames = cms.untracked.vstring('/store/t0streamer/Data/HIPhysicsCommissioning/000/325/112/run325112_ls0006_streamHIPhysicsCommissioning_StorageManage
r.dat')
)

I get the following problem:

----- Begin Fatal Exception 26-Oct-2018 06:44:50 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
[0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found:
hiConformalPixelTracks after hiConformalPixelTracksPhase1Filter [path reconstruction_step], hiConformalPixelTracksPhase1Filter after pixelFitterByConformalMappingAndLine [path reconstruction_step], pixelFitterByConformalMappingAndLine after hiConformalPixelTracksPhase1HitQuadrupletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitQuadrupletsCA after hiConformalPixelTracksPhase1HitDoubletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitDoubletsCA after hiConformalPixelTracksPhase1SeedLayers [path reconstruction_step], hiConformalPixelTracksPhase1SeedLayers after hiConformalPixelTracksPhase1TrackingRegions [path reconstruction_step], hiConformalPixelTracksPhase1TrackingRegions after hiClusterCompatibility [path reconstruction_step], hiClusterCompatibility after hiCentrality [path reconstruction_step], hiCentrality consumes hiConformalPixelTracks
Running in the threaded framework would lead to indeterminate results.
Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------

@tocheng
Copy link
Contributor Author

tocheng commented Oct 26, 2018

@fabiocos
@mmusich did some test. The error has nothing to do with PR and doesn't appear in 10_3_X

Hello @fabiocos, @slava77,
while this PR runs fine in the last IB of 10.3.X using:

python $CMSSW_BASE/src/Configuration/DataProcessing/test/RunExpressProcessing.py --scenario ppEra_Run2_2018_pp_on_AA --global-tag 103X_dataRun2_Express_v1 --lfn /store/t0streamer/Data/HIExpress/000/325/112/run325112_ls0013_streamHIExpress_StorageManager.dat --fevt --dqmio --alcareco DtCalib

and then changing the event source with:

process.source = cms.Source("NewEventStreamFileReader"

while doing the same in 10.4.X I notice I incur in this error:

----- Begin Fatal Exception 25-Oct-2018 22:56:57 CEST-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Module run order problem found: 
hiConformalPixelTracks after hiConformalPixelTracksPhase1Filter [path reconstruction_step], hiConformalPixelTracksPhase1Filter after pixelFitterByConformalMappingAndLine [path reconstruction_step], pixelFitterByConformalMappingAndLine after hiConformalPixelTracksPhase1HitQuadrupletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitQuadrupletsCA after hiConformalPixelTracksPhase1HitDoubletsCA [path reconstruction_step], hiConformalPixelTracksPhase1HitDoubletsCA after hiConformalPixelTracksPhase1SeedLayers [path reconstruction_step], hiConformalPixelTracksPhase1SeedLayers after hiConformalPixelTracksPhase1TrackingRegions [path reconstruction_step], hiConformalPixelTracksPhase1TrackingRegions after hiClusterCompatibility [path reconstruction_step], hiClusterCompatibility after hiCentrality [path reconstruction_step], hiCentrality consumes hiConformalPixelTracks
 Running in the threaded framework would lead to indeterminate results.
 Please change order of modules in mentioned Path(s) to avoid inconsistent module ordering.
----- End Fatal Exception -------------------------------------------------

the same error is also obtained in a vanilla CMSSW_10_4_X_2018-10-25-1100.
Is there any substantial difference between the tip of 10.3.X and the tip of 10.4.X that can cause this?

@fabiocos
Copy link
Contributor

ok, I confirm that with the latest fix of @slava77 #25011 the PR looks to work

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 29a4912 into cms-sw:master Oct 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants