Phase2-hgx167 Fix a bug for the corner calculations #25027
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25027/7003 |
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: Geometry/HGCalGeometry @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild Please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
@ianna Could you review this PR? |
|
+upgrade |
| if (m_det == DetId::HGCalHSc) { | ||
| std::pair<double,double> rr = m_topology.dddConstants().cellSizeTrap(id.iType,id.iSec1); | ||
| float dx = 0.5*(rr.second-rr.first); | ||
| float dy = 0.5*(rr.second+rr.first)*m_cellVec2[cellIndex].param()[11]; |
There was a problem hiding this comment.
Please don't use magic numbers like 5,7, and 11. Assign constants and use them instead.
There was a problem hiding this comment.
These numbers are standard in various types of calorimeter cells in CaloGeometry. I shall define the names in CaloGeometry package later on and transmit them to use cases in derived geometries.
There was a problem hiding this comment.
I created an issue for this task: #25078
|
+geometry |
cmsbuild
added
fully-signed
geometry-approved
and removed
geometry-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Also provide a new method to return front 6/4 corners and the signed thickness (getNewCorners) which will be useful for visualization of HGCal cells