Fix duplicate generated cfi name #25060
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25060/7055 |
|
A new Pull Request was created by @wddgit (W. David Dagenhart) for master. It involves the following packages: FWCore/Integration @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready Comparison Summary:
|
|
@Dr15Jones and @wddgit do we have any unit tests to load/use this? |
|
Actually no. This cfi file is not used in any test. There are some other options here. Alternative 1. I could change this module to just not generate a cfi file at all. We have other tests that test cfi file generation and test using generated cfi files. We do not need to test this with this module. Alternative 2. I could change the cfg.py files that use the module to use the cfi. Currently they just explicitly create the module themselves as that was the simplest thing to do. There is not much in the cfi file. I just did the simplest thing to avoid the error. I don't really care much and am happy to do it some other way if someone wants. The only use of the cfi files would be if someone wanted to use the cfi file in some new or temporary test it would already exist ... |
|
I vote for just leaving this pull request as it is. |
|
@smuzaffar is it ok for you? |
|
yes, I am fine with the change. |
|
+1 |
No description provided.