New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HLT and GT packer for new HI L1 objects #25064
Update HLT and GT packer for new HI L1 objects #25064
Conversation
apana
commented
Oct 30, 2018
- Update firmware version in cfi for uGT packer (gtStage2Raw_cfi.py) to pack new HI L1 objects
- Update HLT so TriggerFilterObjectWithRefs objects get filled properly for new HI L1 objects
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25064/7058 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25064/7058/git-diff.patch You can run |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25064/7059 |
A new Pull Request was created by @apana (Leonard Apanasvich) for master. It involves the following packages: DataFormats/HLTReco @cmsbuild, @Martin-Grunewald, @nsmith-, @rekovic, @thomreis, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Hi @apana What is the type of the new variables? Are they (all?) global event variables (such as ET, ETmiss, HT), ie, one value per event, or could there be several objects of each (or some) variable in an event, (such as there could be several muons in an event, for example)? I am asking because I need to pack this up at HLT level also... |
@@ -12,7 +12,8 @@ | |||
JetInputTag = cms.InputTag("simCaloStage2Digis"), | |||
EtSumInputTag = cms.InputTag("simCaloStage2Digis"), | |||
FedId = cms.int32(1404), | |||
FWId = cms.uint32(0x10A6), # FW version in GMT with vtx-etrapolation | |||
## FWId = cms.uint32(0x10A6), # FW version in GMT with vtx-etrapolation | |||
FWId = cms.uint32(0x10F2), # FW version for packing new HI centrality variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FwId has increased, and the new version only adds records to pack, not remove any existing records, so should be backward compatible.
Comparison job queued. |
Comparison is ready Comparison Summary:
|
All these new event variables are stored in the already existing class DataFormats/L1Trigger/interface/EtSum.h, and the added enums flags what the actual variable is? |
Comments:
To figure out what is needed for the trigger summary, I need more clarifications, especially on the question: |
In addition, some of these types, but lesser number, were also missing from DataFormats/L1TGlobal/src/GlobalObject.cc (for example
|
+1 |
For the record, discussing with @Martin-Grunewald the TriggeSummary will have to be update after 10_3_1 (if this has to be done on 1 day time scale). It might imply an update of the event content, to be clarified |
@Martin-Grunewald if you have no doubts on this PR in itself, are you ready to sign it so as we can proceed with the integration in view of 10_3_1/ |
I would have wished @apana to comment also. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hi Martin, I'm sorry I didn't reply back. I had thought Vladimir answer was sufficient, but in the future I will reply back to make sure. Do you still have any questions? Also, please let me know if you want me to look into updating the TriggerSummary code. |
Hi Len, If you look at my specific commenst on the code changes, you see that I am worried that not all the new variables have been added in all locations, as the number of "blocks" added varies. |