New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup DQM/CSCMonitorModule #25124
Cleanup DQM/CSCMonitorModule #25124
Conversation
The declaration of unused function makes future maintenance harder.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25124/7121 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/CSCMonitorModule @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hi @Dr15Jones, are you planning to test this PR in playback? |
I presume there will not be a back-port to this PR. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
See #25128 (comment) for response to playback and back-port questions. |
+1 it looks a technical cleaning whose backport to 10_3_X is likely unnecessary |
-Removed an unnecessary build dependency
-Removed unneeded function declarations in CSCMonitorModule. This will help future code migration.