HCAL: HF SIM update for >= Run2

[abdoulline]

Follow up on a discussion back in August at HCAL DPG meeting
https://indico.cern.ch/event/745475/contributions/3080994/attachments/1697133/2732028/HF_MC_Update_Aug3_2018_v3.pdf

Some more plots will be presented at HCAL DPG this Friday (Nov.9)
https://indico.cern.ch/event/768831/
Doesn't change much HF energy scale, while improves low-energy (single p.e. domain) agreement of HF spectrum with data.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25155/7151

[cmsbuild]

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

SimCalorimetry/HcalSimProducers
SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31522/console Started: 2018/11/07 18:38

[cmsbuild]

+1
Tested at: a66164e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25155/31522/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25155/31522/summary.html

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 28078 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2993155
• DQMHistoTests: Total failures: 86368
• DQMHistoTests: Total nulls: 5
• DQMHistoTests: Total successes: 2906585
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.265 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -1.253 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.059 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.047 KiB SiStrip/MechanicalView
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31641/console Started: 2018/11/13 22:21

[cmsbuild]

+1
Tested at: a66164e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25155/31641/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25155/31641/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25155/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35

Comparison Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 25029 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 89815
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2923292
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -1.851 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -1.253 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 250202.181 ): -0.645 KiB SiStrip/MechanicalView
• DQMHistoSizes: changed ( 25202.0 ): 0.047 KiB SiStrip/MechanicalView
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

@abdoulline @civanch I guess that the large bunch of changes in the DQM plots is driven by a modification in the Geant4 event history, I do not see why HF digis should affect tracking plots , am I correct?

[abdoulline]

Yes Fabio, this is my perception - GEANT rndm changed. That was visible in old tests of the changes implemented in this PR - namely even ECAL SimHits changed all over ECAL https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/HF_10_2_X/10_2_0_pre6_newHF3_vs_10_2_0_pre6_SinglePi/SimHitsTask_emean_vs_ieta_E.gif

…

On Wed, 14 Nov 2018, Fabio Cossutti wrote: @abdoulline @civanch I guess that the large bunch of changes in the DQM plots is driven by a modification in the Geant4 event history, I do not see why HF digis should affect tracking plots , am I correct? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.[AEx02p8Fv3SkdIpqbZx-ijd51MLknBG0ks5uu7pBgaJpZM4YS0eg.gif]

[fabiocos]

+1

[civanch]

@abdoulline , @fabiocos , the line responsible for history change:
run2_common.toModify( g4SimHits.HFShower, ProbMax = 0.5)