Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save repacked raw data in FVT, for express wfs #25178

Merged
merged 1 commit into from Nov 10, 2018
Merged

Save repacked raw data in FVT, for express wfs #25178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions Configuration/EventContent/python/EventContent_cff.py
View file
Open in desktop
Expand Up @@ -412,7 +412,8 @@
'drop *',
'drop FEDRawDataCollection_*_*_*',
'keep FEDRawDataCollection_rawDataRepacker_*_*',
'keep FEDRawDataCollection_virginRawDataRepacker_*_*'),
'keep FEDRawDataCollection_virginRawDataRepacker_*_*',
'keep FEDRawDataCollection_rawDataReducedFormat_*_*'),
splitLevel = cms.untracked.int32(0),
)
REPACKRAWSIMEventContent = cms.PSet(
Expand Down Expand Up @@ -728,6 +729,8 @@
REPACKRAWEventContent.outputCommands.extend(['drop FEDRawDataCollection_source_*_*',
'drop FEDRawDataCollection_rawDataCollector_*_*'])



#from modules in Configuration.StandardSequence.Generator_cff fixGenInfo
REGENEventContent = cms.PSet(
inputCommands=cms.untracked.vstring(
Expand Down Expand Up @@ -880,11 +883,12 @@ def SwapKeepAndDrop(l):
from Configuration.Eras.Modifier_run2_GEM_2017_cff import run2_GEM_2017
from Configuration.Eras.Modifier_run3_GEM_cff import run3_GEM
from Configuration.Eras.Modifier_phase2_muon_cff import phase2_muon
from Configuration.Eras.Modifier_pp_on_AA_2018_cff import pp_on_AA_2018
for _entry in [FEVTDEBUGEventContent,FEVTDEBUGHLTEventContent,FEVTEventContent]:
run2_GEM_2017.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])
run3_GEM.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])
phase2_muon.toModify(_entry, outputCommands = _entry.outputCommands + ['keep *_muonGEMDigis_*_*'])

pp_on_AA_2018.toModify(_entry, outputCommands = _entry.outputCommands + ['keep FEDRawDataCollection_rawDataRepacker_*_*'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why does this need to be handled separately from the rest?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidlange6 do you mean not modifying directly the RAW content?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no simple obvious alternative that's clearly not going to break anything outside of pp_on_AA

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 the initial simple attempt to modify RAW was not working...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 the initial simple attempt to modify RAW was not working...

I'm not sure if this is connected with David's comment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slava77 well, the modification tried was just for pp_on_AA, changing the base definition is different. I do not see how this change might break other things, and I have checked that it solves the observed problem, so in principle it may be merged if a fast patch is needed


from RecoLocalFastTime.Configuration.RecoLocalFastTime_EventContent_cff import RecoLocalFastTimeFEVT, RecoLocalFastTimeRECO, RecoLocalFastTimeAOD
from Configuration.Eras.Modifier_phase2_timing_layer_cff import phase2_timing_layer
Expand Down