Add options to write out modules timings dictionary to a yaml file #25182
Conversation
|
The code-checks are being triggered in jenkins. |
|
@knoepfel @Dr15Jones please review |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25182/7180 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: FWCore/Concurrency @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -5,6 +5,7 @@ | |||
| import sys | |||
| from collections import defaultdict | |||
| import six | |||
| import yaml | |||
There was a problem hiding this comment.
Given that yaml is not part of the standard python package, we should avoid requiring all calls to the script requiring it to load.
| @@ -345,6 +346,27 @@ def findStalledModules(processingSteps, numStreams): | |||
| t.append(waitTime) | |||
| return stalledModules | |||
|
|
|||
|
|
|||
| def createModuleTiming(processingSteps, numStreams): | |||
|
|
|||
There was a problem hiding this comment.
add import yaml here to reduce the coupling.
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25182/7181 |
|
Pull request #25182 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
for use elsewhere.