Updated trackerStablePhiSort and mtdStablePhiSort #25196
Conversation
|
The code-checks are being triggered in jenkins. |
| { | ||
| // ordered.... | ||
| std::vector<double> phis; phis += -0.1683, -0.0561, +0.0000, +0.0561 +0.1683; |
There was a problem hiding this comment.
I'd like to point out this nice example of why too much "boost magic" can be dangerous. Did the author intend to insert +0.0561 and +0.1683 as different elements and just forgot a comma, or was it really the idea to add the doubles and then insert the sum? We will never know...
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25196/7204 |
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: Geometry/MTDNumberingBuilder @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+upgrade |
|
Pull request #25196 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again. |
|
ping for testing please! |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
+upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Hi, this is a follow up on #24549, where I had to wrap some functions which did not inherit anymore from the
unary_functionintostd::functionssuch that they could be used with the trackerStablePhiSort and mtdStablePhiSort. I knew that was not the most elegant solution, but since #24549 was already a huge PR I accepted it for now.Here I propose a better solution with is to rewrite trackerStablePhiSort and mtdStablePhiSort in a way that they can take arbitrary function objects, including normal functions and lambdas. Basically the same as I did here #25080 for the precomputed_value_sort.