Egamma PhotonMVANtuplizer.cc completion #25218
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25218/7233 |
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages: RecoEgamma/PhotonIdentification @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
| // See if the closest photon (if it exists) is close enough. | ||
| // If not, no match found. | ||
| if(dR < deltaR) { | ||
| if( closestPhoton->isPromptFinalState() ) return TRUE_PROMPT_PHOTON; |
There was a problem hiding this comment.
this is triggering a new issue in the static analyzer.
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25218/31629/llvm-analysis/report-1f898d.html#EndPath
Please fix.
A somewhat easy alternative is to move this code to /test subdirectory.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25218/7346 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Hi,
maybe you give me a free pass updating the PhotonMVANtuplizer in CMSSW, even if it is not used in production? The equivalent ElectronMVANtuplizer was well received and is now used by quite a few people for little studies. It's a quick and safe way to get a flat electron ntuple with the exact same ID variables and signal/background definition as in the MVAs used in production.
For the photons, I did not dare implementing the same functionality since I'm not so familiar with them. The PhotonMVANtuplizer was so far only able to dump final ID scores to validate them. However, I got many requests to implement the matching and dumping of ID variables also in the PhotonMVANtuplizer, and teamed up with @kmondal to implement the same "gen" matching as in the flashgg framework.
Getting this into release would keep me from maintaining one more private branch which people have to merge.
This might be interesting for @fcouderc and @mhuwiler, and of course @michelif and @swagata87 should somehow approve this first.
Here a little histogram with the pT of the different reco photon populations, as a first quick validation.