Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[102X] Change GT. Fix 2016 MC ECAL PF Rechit thresh #25253

Merged
merged 1 commit into from
Nov 21, 2018

Conversation

@lpernie
Copy link
Contributor Author

lpernie commented Nov 15, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 15, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31680/console Started: 2018/11/15 19:21

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lpernie (Luca Pernie) for CMSSW_10_2_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor Author

lpernie commented Nov 15, 2018

backport of #25256 and #25255

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25253/31680/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2561 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2986766
  • DQMHistoTests: Total failures: 2091
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2984485
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Nov 16, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@franzoni
Copy link

greetings @lpernie @tocheng
can you describe what fix is being deployed here ?
Thanks!

@lpernie
Copy link
Contributor Author

lpernie commented Nov 20, 2018

Hi @franzoni ,
The ECAL rechit PF thresholds was an hardcoded value in the past. Later this threshold has been ported into the GT with the EcalPFRecHitThresholds TAG.
2016 GTs in autocond contains 2018 TAG, and not the 2016 one. This is what has been fixed by this PR.

@fabiocos
Copy link
Contributor

@lpernie so you confirm that this is updating autoCond to the GT used for MC production

@lpernie
Copy link
Contributor Author

lpernie commented Nov 21, 2018

Hi @fabiocos . The is currently no MC production for 2016.
The production will be for ultralegacy, using 104X release where this fix to the 2016 GT already has been merged.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa01d1b into cms-sw:CMSSW_10_2_X Nov 21, 2018
@franzoni
Copy link

thanks @lpernie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants