Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim: fix NaNs in EnergyLoss material interaction -- backport to 94X #25259

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Nov 16, 2018

Backport of #25258 to 94X.
Fixes NaNs in the EnergyLoss material interaction.

@ssekmen
Copy link
Contributor Author

ssekmen commented Nov 16, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31689/console Started: 2018/11/16 05:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2018

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

FastSimulation/SimplifiedGeometryPropagator

@cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25259/31689/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721223
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@ssekmen
Copy link
Contributor Author

ssekmen commented Nov 16, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@ssekmen I am confused, was this PR closed on purpose?

@ssekmen ssekmen reopened this Nov 16, 2018
@ssekmen
Copy link
Contributor Author

ssekmen commented Nov 16, 2018

@fabiocos , this must have been an accident.

@kpedro88
Copy link
Contributor

backport of #25258

@prebello
Copy link
Contributor

prebello commented Nov 19, 2018

Hi @fabiocos we are using 9-4-11-patch1 for FastSim central MC production. Could you please let us know if patch2 is in the way to cover this PR?
Thank you

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a537571 into cms-sw:CMSSW_9_4_X Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants