-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastSim: fix NaNs in EnergyLoss material interaction -- backport to 94X #25259
FastSim: fix NaNs in EnergyLoss material interaction -- backport to 94X #25259
Conversation
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X. It involves the following packages: FastSimulation/SimplifiedGeometryPropagator @cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@ssekmen I am confused, was this PR closed on purpose? |
@fabiocos , this must have been an accident. |
backport of #25258 |
Hi @fabiocos we are using 9-4-11-patch1 for FastSim central MC production. Could you please let us know if patch2 is in the way to cover this PR? |
+1 |
Backport of #25258 to 94X.
Fixes NaNs in the EnergyLoss material interaction.