Include missing header in ThreadSafeStringCut.h

[perrotta]

Not clear why the automatic check did not notice it while merging #25101, but now the following message shows up in the log of the jenkins tests for header consistency:

src/RecoEgamma/EgammaTools/interface/ThreadSafeStringCut.h:40:5: error: 'CMS_THREAD_SAFE' does not name a type; did you mean '_SC_THREADS'?
     CMS_THREAD_SAFE mutable std::mutex mutex_;

The inclusion of

#include "FWCore/Utilities/interface/thread_safety_macros.h"

seems to be missing.

This PR wants to add it

[cmsbuild]

The code-checks are being triggered in jenkins.

[perrotta]

@guitargeek

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25261/7282

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[guitargeek]

Thanks Andrea! Sorry for missing that.

[fabiocos]

@smuzaffar @perrotta this is a genuine header problem reported by the check in #25208 that did not directly affect the header, that was anyway not reported in #25101 . Rerunning for #25101 the PR test scram b -k check-headers of CMSSW_10_4_X_2018-11-13-2300 does not mention the affected header. Is it clear why?

As recently we had a number of fake messages in the header check I did not pay too much attention to that and unfortunately I overlooked the report in #25208

[perrotta]

@cmsbuild please test
(@smuzaffar : tests are stuck here. I'm trying now to restart them, but if it doesn't work some other action is required)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31711/console Started: 2018/11/17 11:47

[cmsbuild]

+1
Tested at: ff5b06d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25261/31711/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25261/31711/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013110
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Bug fix: included missing header
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1