Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RPCtoDTTranslator #25275

Merged
merged 11 commits into from
Nov 20, 2018
Merged

Fix RPCtoDTTranslator #25275

merged 11 commits into from
Nov 20, 2018

Commits on Nov 18, 2018

  1. Reset itr2 before call to each inner loop 

    This avoids a crash seen in production.
In addition, moved declaration of additional loop variables to be
within the scope of the loop.
    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    7eced50 View commit details
    Browse the repository at this point in the history

  2. Do not copy RPCDigiCollection 

    The constructor now holds a const& to the collection.
    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    2e1e2d0 View commit details
    Browse the repository at this point in the history

  3. moved struct rpc_hit to implementation file

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    d6ae57c View commit details
    Browse the repository at this point in the history

  4. Use emplace back for std::vector<rpc_hit>

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    bb2e431 View commit details
    Browse the repository at this point in the history

  5. Avoid calling function on nullptr 

    Create a L1MuTMChambPhContainer on the stack rather than having
a pointer to null.
Also made calling arguments const.
    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    1b118cc View commit details
    Browse the repository at this point in the history

  6. Properly scoped loop internal variables

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    5f66c38 View commit details
    Browse the repository at this point in the history

  7. Made helper classes stack local instead of on the heap 

    The helper classes were being made each call and where being allocated
via a shared_ptr. Putting them on the stack is more efficient.

Also tried to avoid some copies of returned values.
    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    8160364 View commit details
    Browse the repository at this point in the history

  8. Avoid making unnecessary copies in DTLowQMatching

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    e32e2e3 View commit details
    Browse the repository at this point in the history

  9. Avoid unnecessary copy in RPCHitCleaner

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    a08e83a View commit details
    Browse the repository at this point in the history

  10. Hold digis by const& to avoid a copy

    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    04bed52 View commit details
    Browse the repository at this point in the history

  11. Removed unnecessary use of shared_ptr 

    Moved the variables to be on the stack. They have the same lifetime
as before but can be handled more efficiently.
    @Dr15Jones
    Dr15Jones committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    29a8a53 View commit details
    Browse the repository at this point in the history