L1T CaloL2: Fix MPUnpacker so that it does not go out of range for old test run #25303
Conversation
|
The code-checks are being triggered in jenkins. |
|
Fixes issue #25121 |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25303/7327 |
|
A new Pull Request was created by @bundocka for master. It involves the following packages: EventFilter/L1TRawToDigi @nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
please test workflow 136.733 |
cmsbuild
added
comparison-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Hi @fabiocos do we need backports for this fix? |
|
@thomreis well reading out of bounds does not sound an healthy behaviour, I would advice a backport. |
|
This unpacker is for an old firmware version that was used during commissioning. It appears there is a run that is used in the comparisons where the firmware version satisfies the condition to call this specific unpacker, but the extra frame is not present in the readout. There was only a short period where this firmware version was used in May 2016, for firmware versions used shortly after this the frame is in the readout and the unpacker does not try to read out of bounds. |
There appears to be a run 272133 where the firmware version was updated, but the additional output required by the versioned unpacker is not present in the readout. This was during commissioning of the Stage 2 trigger. I've added a check that makes sure the unpacker doesn't go outside the block length.