Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run2-alca147 Add a new class for low lumi runs #25379

Merged
merged 4 commits into from Dec 18, 2018

Conversation

bsunanda
Copy link
Contributor

Good for muon calibration of HCAL

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31914/console Started: 2018/11/29 22:11

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25379/31914/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131633
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32182/console Started: 2018/12/13 23:17

@cmsbuild
Copy link
Contributor

Pull request #25379 was updated. @tocheng, @cmsbuild, @franzoni, @pohsun, @davidlange6, @fabiocos, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25379/32182/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136423
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3136216
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.016 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@bsunanda
Copy link
Contributor Author

@pohsun @fabiocos Can you approve and merge this PR at the earliest?

@mariadalfonso
Copy link
Contributor

@tocheng, @lpernie is ok for you this PR ?
we would like to have it for the 10_4_0_pre5

@tocheng
Copy link
Contributor

tocheng commented Dec 17, 2018

+1

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d4d690b into cms-sw:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants