Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define new run2_miniAOD_devel and run2_nanoAOD_102Xv1 modifiers [102X] #25444

Merged
merged 2 commits into from Dec 11, 2018
Merged

Define new run2_miniAOD_devel and run2_nanoAOD_102Xv1 modifiers [102X] #25444

merged 2 commits into from Dec 11, 2018

Conversation

peruzzim
Copy link
Contributor

@peruzzim peruzzim commented Dec 7, 2018

This is the backport of #25443

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @peruzzim for CMSSW_10_2_X.

It involves the following packages:

Configuration/Eras

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Pull request #25444 was updated. @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please check and sign again.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 8, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32079/console Started: 2018/12/08 22:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25444/32079/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007299
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007104
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@peruzzim
Copy link
Contributor Author

backport #25443

please merge this to allow using this functionality in other open PRs

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants