Ecal TPG Weights definition by strip number #25510

depasse · 2018-12-18T07:51:14Z

Before, in Ecal, it was only a distinction between EB/EE. But we have to refine the granularity due to the big variation of laser transparency in the crystals.

cmsbuild · 2018-12-18T07:51:32Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-12-18T07:57:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25510/7680

cmsbuild · 2018-12-18T07:57:19Z

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ggovi · 2018-12-19T09:13:15Z

please test

cmsbuild · 2018-12-19T09:15:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32269/console Started: 2018/12/19 10:16

ggovi · 2018-12-19T09:16:24Z

CondTools/Ecal/src/EcalTPGWeightIdMapHandler.cc

-	  edm::LogInfo("got offlineInfo = ");
-	  edm::LogInfo("tag name = ") << tagInfo().name;
-	  edm::LogInfo("size = ") << tagInfo().size;
+    	std::cout << "got offlineInfo = " << std::endl;


Why the edm::LogInfo ( which is the correct way to implement logging ) has been turned to std::cout statements?

cmsbuild · 2018-12-19T11:33:02Z

-1

Tested at: 747f665

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25510/32269/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

Unit Tests:

I found errors in the following unit tests:

---> test EcalTPGWeightGroup_O2O_test had ERRORS

cmsbuild · 2018-12-19T11:33:05Z

Comparison job queued.

cmsbuild · 2018-12-19T13:28:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25510/32269/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153512
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

…ew format

fabiocos · 2018-12-27T14:24:52Z

please test

cmsbuild · 2018-12-27T14:26:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32374/console Started: 2018/12/27 15:28

cmsbuild · 2018-12-27T15:35:51Z

+1
Tested at: 6e3991c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25510/32374/summary.html

cmsbuild · 2018-12-27T15:35:55Z

Comparison job queued.

cmsbuild · 2018-12-27T16:46:38Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25510/32374/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153512
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ggovi · 2019-01-08T13:47:19Z

+1

cmsbuild · 2019-01-08T13:47:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-09T09:19:52Z

code-checks

cmsbuild · 2019-01-09T09:20:23Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-09T09:26:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25510/7886

This PR adds an extra 28KB to repository

fabiocos · 2019-01-09T09:52:18Z

+1

Ecal TPG Weights definition by strip number

747f665

cmsbuild added this to the CMSSW_10_4_X milestone Dec 18, 2018

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Dec 18, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 18, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 19, 2018

ggovi reviewed Dec 19, 2018

View reviewed changes

cmsbuild added tests-rejected and removed tests-started labels Dec 19, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 19, 2018

Ecal TPG Weights definition by strip number, O2O correction for the n…

6e3991c

…ew format

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-rejected labels Dec 19, 2018

smuzaffar added this to the CMSSW_10_5_X milestone Dec 20, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 27, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 27, 2018

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jan 8, 2019

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 9, 2019

cmsbuild merged commit ccf9331 into cms-sw:master Jan 9, 2019

depasse deleted the EcalTPGParamWeightGroup branch January 11, 2023 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ecal TPG Weights definition by strip number #25510

Ecal TPG Weights definition by strip number #25510

depasse commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

ggovi commented Dec 19, 2018

cmsbuild commented Dec 19, 2018 •

edited

ggovi Dec 19, 2018

cmsbuild commented Dec 19, 2018

cmsbuild commented Dec 19, 2018

cmsbuild commented Dec 19, 2018

fabiocos commented Dec 27, 2018

cmsbuild commented Dec 27, 2018 •

edited

cmsbuild commented Dec 27, 2018

cmsbuild commented Dec 27, 2018

cmsbuild commented Dec 27, 2018

ggovi commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fabiocos commented Jan 9, 2019

Ecal TPG Weights definition by strip number #25510

Ecal TPG Weights definition by strip number #25510

Conversation

depasse commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

cmsbuild commented Dec 18, 2018

ggovi commented Dec 19, 2018

cmsbuild commented Dec 19, 2018 • edited

ggovi Dec 19, 2018

Choose a reason for hiding this comment

cmsbuild commented Dec 19, 2018

cmsbuild commented Dec 19, 2018

cmsbuild commented Dec 19, 2018

fabiocos commented Dec 27, 2018

cmsbuild commented Dec 27, 2018 • edited

cmsbuild commented Dec 27, 2018

cmsbuild commented Dec 27, 2018

cmsbuild commented Dec 27, 2018

ggovi commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Dec 19, 2018 •

edited

cmsbuild commented Dec 27, 2018 •

edited