Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MTD reconstruction - 104X backport of 25063 #25541

Merged
merged 25 commits into from Dec 21, 2018
Merged

MTD reconstruction - 104X backport of 25063 #25541

merged 25 commits into from Dec 21, 2018

Conversation

fabiocos
Copy link
Contributor

Backport of #25063 - 1st Version of MTD Hit-Finder and Track Refitter

lgray and others added 25 commits December 20, 2018 19:53
@lgray @fabiocos
Initial version of MTDTrackExtender
5b4275c
@bendavid @fabiocos
preliminary backpropagation implementation
aadbd4b
@bendavid @fabiocos
more robust backpropagation, now one layer at a time
bd6e225
@pmeridian @fabiocos
First running version
c5b58da
@pmeridian @fabiocos
debugging completed
7314e30
@pmeridian @fabiocos
Start debugging
2bca3d9
@pmeridian @fabiocos
Fixng CPE name
d73d223
@pmeridian @fabiocos
debugging. adding time error
173e16f
@lgray @fabiocos
code review 1
f68d970
@pmeridian @fabiocos
Fixes for new BTLDetId CrysLayout from topology
1c53524
@pmeridian @fabiocos
back to MTDTrackingRecHit with ClusterRef
57d043d
@pmeridian @fabiocos
Adding back MTDTrackingRecHit with MTDClusterRef
2aedd1f
@pmeridian @fabiocos
using mtdTrackingRecHits as input
bed4edb
@pmeridian @fabiocos
adding RecoMTD globalreco to the Reco sequence. Updating also track w…
73d9c82 
…ith refitted with MTD hits
@pmeridian @fabiocos
more consistent use of trajWithMtd
fd3c4a2
@lgray @fabiocos
rebase cleanup and code review
0ae97a5
@pmeridian @fabiocos
Addressing PR comments (from Paolo)
7a11ea0
@lgray @fabiocos
further code review
e465b54
@pmeridian @fabiocos
addressing slava comments
f5a4e97
@pmeridian @fabiocos
addressing slava comments part2
b9d1452
@lgray @fabiocos
fill value maps at correct nesting of loops
0b75dce
@pmeridian @fabiocos
last comments from Slava on localReco
493b4b5
@lgray @fabiocos
PSetDesc fix + Kevin
d3a8d0a
@lgray @fabiocos
residual commit
cf75e2f
@pmeridian @fabiocos
avoid unnecessary unique_ptr
3d8d8ba
@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Dec 20, 2018
@fabiocos
Copy link
Contributor Author

as agreed with @kpedro88 and @slava77 I merge this PR to prepare a CMSSW_10_4_0_mtd3 build for further tests before a final merge in master

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit d047c7b into cms-sw:CMSSW_10_4_X Dec 21, 2018
@lgray lgray mentioned this pull request Jan 9, 2019
Merged
@lgray
Copy link
Contributor

lgray commented Jan 9, 2019

Residual commits now backported in #25613

@andrius-k
Copy link

+1

cmsbuild added a commit that referenced this pull request Jan 11, 2019
@cmsbuild
Merge pull request #25613 from lgray/topic_25541_continued
d65593d 
Further backport of MTD reconstruction to 10_4_X (continuation of #25541, backport of #25063)
@fabiocos fabiocos deleted the fc-bp25063 branch January 24, 2019 15:01
@cvuosalo
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@cvuosalo @silviodonato I believe that this old PR should just be closed, I do not see any use case for it (I actually had forgotten it). @pmeridian @parbol do you agree?

@silviodonato
Copy link
Contributor

@fabiocos this old PR was merged in 2018. Likely you got a notification because Carl just signed it to remove the "geometry-pending" tag.

@fabiocos
Copy link
Contributor Author

@silviodonato you are correct, I was also confused by the list of missing signatures. Ok, this was an intermediate step in the preparation of the final _mtd version, no problem

@jfernan2
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport comparison-available dqm-approved geometry-approved hlt-pending operations-approved orp-approved pending-signatures reconstruction-approved simulation-pending tests-approved tracking upgrade-pending
Projects
None yet
Milestone
CMSSW_10_4_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@fabiocos @cmsbuild @lgray @andrius-k @cvuosalo @silviodonato @jfernan2 @bendavid @pmeridian