Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiStripAPVGain PCL: protect reading G1 gain from DB #25544

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 21, 2018

... as the measurement not necessarily available for all channels in Run-1 IOVs.
Solves issue #23798.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripChannelGain

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @gbenelli, @tocheng, @alesaggio, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich mmusich changed the title SiStripAPVGain PCL: protect reading G1gain from DB SiStripAPVGain PCL: protect reading G1 gain from DB Dec 21, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Jan 7, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32432/console Started: 2019/01/07 14:31

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25544/32432/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153500
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Jan 13, 2019

+1
Thanks for the detailed explanation.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25544/7977

  • This PR adds an extra 24KB to repository

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6900a30 into cms-sw:master Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants