Avoid comparing unrelated enums in cond::Time #25557

Dr15Jones · 2018-12-21T21:53:45Z

By using 'static constexpr' instead of an enum we preserve the type of the value while changing the name. This avoids a clang warning.

Also removed the unused _typetype global variable.

By using 'static constexpr' instead of an enum we preserve the type of the value while changing the name. This avoids a clang warning. Also removed the unused _typetype global variable.

cmsbuild · 2018-12-21T21:54:38Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-12-21T21:59:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25557/7784

cmsbuild · 2018-12-21T21:59:28Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2018-12-21T22:01:44Z

please test

cmsbuild · 2018-12-21T22:02:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32350/console Started: 2018/12/21 23:02

cmsbuild · 2018-12-22T02:05:23Z

+1
Tested at: cdf5291
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25557/32350/summary.html

cmsbuild · 2018-12-22T02:05:28Z

Comparison job queued.

cmsbuild · 2018-12-22T03:42:22Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25557/32350/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 163
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153350
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

fabiocos · 2019-01-07T14:19:44Z

please test

cmsbuild · 2019-01-07T14:20:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32436/console Started: 2019/01/07 15:21

cmsbuild · 2019-01-07T18:09:10Z

+1
Tested at: cdf5291
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25557/32436/summary.html

cmsbuild · 2019-01-07T18:09:14Z

Comparison job queued.

cmsbuild · 2019-01-07T19:46:24Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25557/32436/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 232
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153281
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ggovi · 2019-01-08T13:42:15Z

+1

cmsbuild · 2019-01-08T13:42:42Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-09T09:13:45Z

@ggovi as far as I can see the failures look more related to L1T non reproducibility than to this PR, could you please confirm?

fabiocos · 2019-01-09T09:17:44Z

code-checks

cmsbuild · 2019-01-09T09:18:11Z

The code-checks are being triggered in jenkins.

ggovi · 2019-01-09T09:21:03Z

@fabiocos
sorry, i'm probably missing something... - which failures?

cmsbuild · 2019-01-09T09:23:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25557/7885

This PR adds an extra 12KB to repository

fabiocos · 2019-01-09T09:50:27Z

@ggovi the DQM histogram tests, 232 look different...

ggovi · 2019-01-09T10:05:48Z

@fabiocos
ok, I don't see how the changes in the histos could be related to this PR. They must be related to something else... can't say about L1T...

fabiocos · 2019-01-09T21:37:49Z

+1

Avoid comparing unrelated enums in cond::Time

cdf5291

By using 'static constexpr' instead of an enum we preserve the type of the value while changing the name. This avoids a clang warning. Also removed the unused _typetype global variable.

cmsbuild added this to the CMSSW_10_5_X milestone Dec 21, 2018

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Dec 21, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 21, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 21, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 22, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 22, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jan 7, 2019

cmsbuild added the tests-started label Jan 7, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 7, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 7, 2019

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jan 8, 2019

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 9, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 9, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 9, 2019

cmsbuild merged commit 714af4a into cms-sw:master Jan 9, 2019

Dr15Jones deleted the clangCondCoreCondDB branch January 11, 2019 14:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid comparing unrelated enums in cond::Time #25557

Avoid comparing unrelated enums in cond::Time #25557

Dr15Jones commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

Dr15Jones commented Dec 21, 2018

cmsbuild commented Dec 21, 2018 •

edited

cmsbuild commented Dec 22, 2018

cmsbuild commented Dec 22, 2018

cmsbuild commented Dec 22, 2018

fabiocos commented Jan 7, 2019

cmsbuild commented Jan 7, 2019 •

edited

cmsbuild commented Jan 7, 2019

cmsbuild commented Jan 7, 2019

cmsbuild commented Jan 7, 2019

ggovi commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

ggovi commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fabiocos commented Jan 9, 2019

ggovi commented Jan 9, 2019

fabiocos commented Jan 9, 2019

Avoid comparing unrelated enums in cond::Time #25557

Avoid comparing unrelated enums in cond::Time #25557

Conversation

Dr15Jones commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

cmsbuild commented Dec 21, 2018

Dr15Jones commented Dec 21, 2018

cmsbuild commented Dec 21, 2018 • edited

cmsbuild commented Dec 22, 2018

cmsbuild commented Dec 22, 2018

cmsbuild commented Dec 22, 2018

fabiocos commented Jan 7, 2019

cmsbuild commented Jan 7, 2019 • edited

cmsbuild commented Jan 7, 2019

cmsbuild commented Jan 7, 2019

cmsbuild commented Jan 7, 2019

ggovi commented Jan 8, 2019

cmsbuild commented Jan 8, 2019

fabiocos commented Jan 9, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

ggovi commented Jan 9, 2019

cmsbuild commented Jan 9, 2019

fabiocos commented Jan 9, 2019

ggovi commented Jan 9, 2019

fabiocos commented Jan 9, 2019

cmsbuild commented Dec 21, 2018 •

edited

cmsbuild commented Jan 7, 2019 •

edited