Allow SiStripBadModuleConfigurableFakeESSource to mask single APVs

[mmusich]

Greetings,
this Pull Request aims to introduce the possibility to produce SiStrip Bad Component payloads, by masking selected single APVs as opposed to the current behavior which allows to mask only entire SiStrip modules. This feature has been useful when creating test SiStrip Bad component payloads in preparation of the 2018 Heavy Ion data-taking, to study the effect on tracking of removing selected problematic APVs (which during data-taking with the tracker in Hybrid mode, were always being readout non zero-suppressed).
I profit of this PR to introduce also a unit test for the SiStripBadModuleConfigurableFakeESSource module, which is used to produce SiStrip Bad Component payload for MC production.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25578/7816

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CalibTracker/SiStripESProducers

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @pieterdavid, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[tocheng]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32417/console Started: 2019/01/05 13:09

[cmsbuild]

+1
Tested at: 84196ee
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25578/32417/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25578/32417/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153511
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[mmusich]

Hi @tocheng is there any outstanding issue with this PR?

[tocheng]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25578/8036

• This PR adds an extra 24KB to repository

[fabiocos]

+1