Use unique bin names in L1TdeStage2CaloLayer1 #25594
Conversation
In the newest version of ROOT, histograms with named bins are merged via the bin's name, not the index. This means we must avoid bins having the same bin names. L1TdeStage2CaloLayer1 has a histogram where the default bin names are set to '-' and then later changed if filled in. This change guarantees uniqueness for the bin names.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25594/7843 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/L1TMonitor @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
In the newest version of ROOT, histograms with named bins are merged via the bin's name, not the index. This means we must avoid bins having the same bin names.
L1TdeStage2CaloLayer1 has a histogram where the default bin names are set to '-' and then later changed if filled in. This change guarantees uniqueness for the bin names.