move testdata to external repo IOPool-Input

[smuzaffar]

• Move testdata in to external data repository cms-data/IOPool-Inout
• Updated unit test to find testdata from external data (using CMSSW_SEARCH_PATH)
• Update TestPoolInput.sh print the command it runs and fail when something goes wrong

[cmsbuild]

The code-checks are being triggered in jenkins.

[smuzaffar]

please test with cms-sw/cmsdist#4627

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25607/7882

• This PR adds an extra 12KB to repository

[cmsbuild]

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4627
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32485/console

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

IOPool/Input

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 4cd0474
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25607/32485/summary.html

[cmsbuild]

Comparison job queued.

[wddgit]

If I build a local working area with IOPool/Input and want to run the
unit tests (something I do regularly), then what is the recipe of
commands I will need to issue to setup these test data files? Or is it
somehow automatic? I'm not complaining, this seems like a reasonable
change. I just want to know what I need to do.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25607/32485/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@wddgit , data files will be available in your dev area too and unit test will automatically find them via CMSSW_SEARCH_PATH

[fabiocos]

+1