Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS Alignment corrections object for condDB #25616

Merged
merged 20 commits into from
Feb 7, 2019

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Jan 9, 2019

We are submitting the CTPPS alignment object definition, CTPPSRPAlignmentCorrectionsData, to be stored in the conditions database.

We are also taking the opportunity of this PR to include some missing tools for reading and writing the local db files for the PPS pixel gain calibrations.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25616/7905

  • This PR adds an extra 200KB to repository

  • Found files with invalid states:

    • Geometry/VeryForwardGeometryBuilder/test/print_alignment_info_DB_cfg.py:
    • CondFormats/CTPPSReadoutObjects/python/CTPPSRPAlignmentCorrectionsDataESSourceXML_cfi.py:

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25616/7905/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25616/7905/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25616/7921

  • This PR adds an extra 208KB to repository

  • Found files with invalid states:

    • Geometry/VeryForwardGeometryBuilder/test/print_alignment_info_DB_cfg.py:
    • CondFormats/CTPPSReadoutObjects/python/CTPPSRPAlignmentCorrectionsDataESSourceXML_cfi.py:

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 6, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25616/33016/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Feb 6, 2019

+1

@forthommel
Copy link
Contributor

@tocheng @pohsun @ggovi ?

@tocheng
Copy link
Contributor

tocheng commented Feb 7, 2019

+1

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

@ggovi I think you may confirm your previous signature, as the update was essentially technical

@ggovi
Copy link
Contributor

ggovi commented Feb 7, 2019

+1

@forthommel
Copy link
Contributor

Thanks, @ggovi ! How about the reco part ? @perrotta, @slava77 ?

@slava77
Copy link
Contributor

slava77 commented Feb 7, 2019

+1

for #25616 d640742

  • code changes since the last reco signoff were in files outside of the reco category
  • jenkins tests pass and comparisons with the baseline show no relevant differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 7, 2019

+1

@cmsbuild cmsbuild merged commit 8354321 into cms-sw:master Feb 7, 2019
@forthommel forthommel deleted the pps_rpalign_db_10_4_X branch February 8, 2019 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet