cleanup uninitialized value use cases based on valgrind checks

[slava77]

several cases of uninitialized value use were picked up in tests of wf 150.0 (10 events) and 136.85 (100 events) with valgrind.

I expect that only the DQM fixes are consequential and will remove/reduce some cases with random differences.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25620/7919

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DQM/SiPixelPhase1Common
DQMOffline/Trigger
RecoMuon/MuonIdentification
SimMuon/RPCDigitizer

@perrotta, @andrius-k, @kmaeshima, @schneiml, @civanch, @mdhildreth, @cmsbuild, @jfernan2, @slava77 can you please review it and eventually sign? Thanks.
@hdelanno, @battibass, @threus, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @jandrea, @mtosi, @idebruyn, @bellan, @rociovilar, @trocino, @bachtis, @folguera, @fioriNTU this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32510/console Started: 2019/01/10 03:31

[cmsbuild]

+1
Tested at: b1a5f4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25620/32510/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25620/32510/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153498
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[andrius-k]

+1

[civanch]

+1

[slava77]

+1

for #25620 b1a5f4a

• jenkins tests pass and comparisons with the baseline show changes that were previously ignored as random.
  • I expect that the random diffs in e.g. wf 136.85 efHLT plots will go away after this PR is merged
  • changes in 150.0 are the same as already noted in the past in random differences in wf 150.0 #25570 . I doubt that this PR will actually get rid of these.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1