-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MTD TimeCalibration (for the moment to remove time offset in BTL) #25634
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25634/7951
|
A new Pull Request was created by @pmeridian for master. It involves the following packages: RecoLocalFastTime/Configuration @perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25634/7953
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25634/8030
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This PR introduces a TimeCalibration applied when producing RecHits.
It is necessary to remove an offset introduced at sim level for BTL to take into account the light propagation time, which changes depending on the different BTL layouts (~0.2ns)
In ETL for the moment only the possibility of a global time offset is introduced, which defaults to 0
This PR address the comment of PR #25628, and allow to produce extendedTracksWithMTD with correctly assigned backpropagated times.
@lgray @bendavid @casarsa