Fixes for BTL Bar simulation

[pmeridian]

Fixes to properly address the BTLBar simulation after the indroduction of the barphiflat configuration. Without this fix this layout is treated as the barzflat.

Also fixes a simple cut& paste mistake where LightCollSlopeR_ was used instead of LightCollSlopeL_. This has no effect since the 2 values are the same.

@lgray @casarsa

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25635/7952

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @pmeridian for master.

It involves the following packages:

SimFastTiming/FastTimingCommon

@cmsbuild, @civanch, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[pmeridian]

@cmsbuild please test

[fabiocos]

please test workflow 27434.0,27834.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32551/console Started: 2019/01/12 16:07

[fabiocos]

thank you @pmeridian , I had adjusted the definition of boundRef but I had overlooked this point.

As we discussed, printing the topology mode and pitch first and second dimensions (x and y according to https://cmssdt.cern.ch/lxr/source/Geometry/MTDGeometryBuilder/interface/RectangularMTDTopology.h#0174 )

for scenario D35 (barzflat) one gets Topology mode = 3 x = 0.287656 y = 6.05
for scenario D38 (barphiflat) one gets Topology mode = 4 x = 6.13333 y = 0.32625
So the fix correctly takes into account the orientation of the strip to define longer size of the bar.

Checking the repository there is no other explicit dependency on the value of the CrysLayout in the code, so this fix should be enough to get correct behaviour.

[cmsbuild]

+1
Tested at: e699e0d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25635/32551/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25635/32551/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25635/27834.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D38_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D38+RecoFullGlobal_2023D38+HARVESTFullGlobal_2023D38

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153500
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[fabiocos]

@kpedro88 is this ok for you? This is a bug fix, not critical for the official production as D38 is not used there, but important for all the internal studies

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1