Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copyright notice to 2019 #25637

Merged
merged 1 commit into from
Jan 21, 2019
Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jan 12, 2019

Explicitly include a copy of the Apache 2.0 LICENSE.

Explicitly include a copy of the Apache 2.0 LICENSE.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25637/7956

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

LICENSE
NOTICE

The following packages do not have a category, yet:

LICENSE
NOTICE
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

@tommasoboccali @klute as discussed at the ORP, we move forward with the integration of this update for the Apache licence
@smuzaffar in practice there is no category and notice for these packages to be assigned as far as I can see. And there is no point in running a test...

@smuzaffar
Copy link
Contributor

we can assign these to core and yes there is not point to run tests.

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32722/console Started: 2019/01/21 09:49

@cmsbuild
Copy link
Contributor

Pull request #25637 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again.

@fabiocos
Copy link
Contributor

@smuzaffar @Dr15Jones given the update in cms-bot your signature is required. I will force a merge without running any useless test

@smuzaffar
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild cmsbuild merged commit 930c41d into cms-sw:master Jan 21, 2019
@fwyzard fwyzard deleted the update_copyright branch January 21, 2019 10:31
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25637/32722/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants