MTD geometry: add scenario D39 equal to D38 but for the crystal thickness

[fabiocos]

This new geometry scenario D39 is equal to D38 (bar along phi in a flat layout), with the exception of the crystal thicknesses in the innermost region (3.6 mm instead of 3.75) and outermost region (2.6 instead of 2.4). These thicknesses are the same as in all scenarios previous to D38, and this geometry is needed to disentangle differences between D38 and D35 due to the bar orientation and to the crystal thickness.

A complete set of upgrade test workflows is added. All the other parameters are kept the same, and also the MTD Topology scenario is the same as for D38.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25639/7959

• This PR adds an extra 80KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData
Geometry/MTDCommonData

@cmsbuild, @prebello, @Dr15Jones, @cvuosalo, @civanch, @ianna, @mdhildreth, @pgunnell, @franzoni, @kpedro88, @zhenhu, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@pmeridian @lgray @abenagli FYI

[fabiocos]

please test

I have put no standard test scenario here to avoid inflating them without need, this is just for private studies and it is identical to D38 in any other respect than crystal thickness:
'''
18:17 lxcloud-fc1 684> diff -b Geometry/MTDCommonData/data/CrystalBarPhiFlat/mtd.xml Geometry/MTDCommonData/data/CrystalBarPhiFlatOldTh/mtd.xml
1614c1614
Box name="BModule1Layer1Timingactive" dx="28.8mm" dy="1.575mm" dz="1.875mm"
Box name="BModule1Layer1Timingactive" dx="28.8mm" dy="1.575mm" dz="1.8mm"
1632c1632
Box name="BModule33Layer1Timingactive" dx="28.8mm" dy="1.575mm" dz="1.2mm"
Box name="BModule33Layer1Timingactive" dx="28.8mm" dy="1.575mm" dz="1.3mm"
'''

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32552/console Started: 2019/01/12 18:19

[cmsbuild]

+1
Tested at: b6f1baf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25639/32552/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25639/32552/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[cvuosalo]

+1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25639/32649/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[cvuosalo]

+1

[kpedro88]

+upgrade

[fabiocos]

+operations

[fabiocos]

@prebello @zhenhu ping

[fabiocos]

@prebello @zhenhu is there any show-stopper with this PR?

[prebello]

+1

no show-stoppers @fabiocos please go ahead.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1