Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove wf 150.0 2018 HeavyIons scenario from short matrix tests #25653

Merged
merged 1 commit into from
Jan 15, 2019

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Jan 14, 2019

HI reco default is now derived from pp scenario.
wf 150.0 is not representative of anything running in production.
it is effectively superseded by 158.0 which is included in the short matrix already.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Jan 14, 2019

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25653/7989

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32590/console Started: 2019/01/14 19:41

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25653/32590/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Jan 15, 2019

@slava77 I agree this looks a fake test (apart for the recent reproducibility issues). Concerning 2018 HI real data, do you consider 140.56 as enough? Or at this point it might be better to update that one as well?

@slava77
Copy link
Contributor Author

slava77 commented Jan 15, 2019

@slava77 I agree this looks a fake test (apart for the recent reproducibility issues). Concerning 2018 HI real data, do you consider 140.56 as enough? Or at this point it might be better to update that one as well?

140.56 looks ok to me (there was a concern about time to completion as discussed in #25210 , but then it seems like that was not a big deal for the tests).
What is your concern about it?

@fabiocos
Copy link
Contributor

@slava77 no concern, just that was the initial part of data taking, I was wondering whether some later file might be more representative

@kpedro88
Copy link
Contributor

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented Jan 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 825f00f into cms-sw:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants