Some more use of new TrackingRecHitRange

[guitargeek]

This was originally meant to be part of #25591, but I decided to split it up the new interface and it's usage in different PRs to not touch too many packages at once.

This PR cleans up some packages from the now deprecated recHitsBegin() and recHitsEnd().

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25663/8000

• This PR adds an extra 172KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

Alignment/CommonAlignmentMonitor
Alignment/CommonAlignmentProducer
Alignment/LaserAlignment
Alignment/MillePedeAlignmentAlgorithm
Alignment/MuonAlignmentAlgorithms
Alignment/OfflineValidation
Alignment/TrackerAlignment
AnalysisAlgos/TrackInfoProducer
CalibTracker/SiPixelErrorEstimation
CalibTracker/SiStripQuality
Calibration/IsolatedParticles
Calibration/TkAlCaRecoProducers
CommonTools/RecoAlgos
FWCore/Utilities
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonAlgos

@perrotta, @smuzaffar, @Dr15Jones, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun, @santocch, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @rappoccio, @felicepantaleo, @jainshilpi, @abbiendi, @Martin-Grunewald, @tlampen, @threus, @varuns23, @pakhotin, @makortel, @jhgoh, @lgray, @jdolen, @pieterdavid, @Sam-Harper, @rovere, @gkasieczka, @tocheng, @mschrode, @mmusich, @clelange, @adewit, @trocino, @gbenelli, @wddgit, @ahinzmann, @dkotlins this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32601/console Started: 2019/01/15 07:02

[cmsbuild]

-1

Tested at: 289fdc4

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25663/32601/summary.html

I found follow errors while testing this PR

Failed tests: Build

• Build:

I found compilation warning when building: See details on the summary page.

[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Pull request #25663 was updated. @perrotta, @smuzaffar, @Dr15Jones, @tocheng, @cmsbuild, @franzoni, @slava77, @pohsun, @santocch, @lpernie can you please check and sign again.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32641/console Started: 2019/01/16 13:50

[cmsbuild]

+1
Tested at: 421d0bf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25663/32641/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25663/32641/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #25663 421d0bf

• code changes are technical and are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences

[pohsun]

+1

[guitargeek]

Hi @Dr15Jones, can you please sign again for core? You have done before but then I made some changes requested by Slava, resetting your signature. Thanks!

[Dr15Jones]

+1
for change to edm::Range

[fabiocos]

+1

[fabiocos]

merge