Delete an unused class rule #25670

yamaguchi1024 · 2019-01-15T14:24:41Z

ROOT::Math::MatRepSym<*> was defined, but was never used in selection
files.

ROOT::Math::MatRepSym<*> was defined, but was never used in selection files.

smuzaffar · 2019-01-15T16:25:48Z

ping bot

cmsbuild · 2019-01-15T16:26:18Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-15T16:31:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25670/8013

This PR adds an extra 12KB to repository

cmsbuild · 2019-01-15T16:32:17Z

A new Pull Request was created by @yamaguchi1024 (Yuka Takahashi) for master.

It involves the following packages:

DataFormats/Math

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2019-01-15T16:33:09Z

please test

cmsbuild · 2019-01-15T16:33:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32620/console Started: 2019/01/15 17:34

cmsbuild · 2019-01-15T18:57:54Z

+1
Tested at: 81f77ec
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25670/32620/summary.html

cmsbuild · 2019-01-15T18:57:59Z

Comparison job queued.

cmsbuild · 2019-01-15T20:51:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25670/32620/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3153717
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3153500
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

smuzaffar · 2019-01-16T09:23:38Z

ok thanks @yamaguchi1024 for the warning.

slava77 · 2019-01-16T16:07:37Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

I'm confused by this , because it's following

Comparison is ready

@smuzaffar
was the error message related to some test started manually by you?
Did that test fail due to the change here or due to some other problems?
Please clarify.
Thank you.

smuzaffar · 2019-01-16T17:24:43Z

@slava77 , yes I wanted to test this PR againt CXXMODULE_X IBs where root has complaint about this unused dictionary but as CXXMODULE_X IB is fully broken that is why I killed the tests and removed the comments which were hiding the original tests results.

Thsi Pr should be good to go now. If still confused then we can restart the tests for normal 10.5.X :-)

slava77 · 2019-01-16T19:03:18Z

DataFormats/Math/src/classes_def.xml

@@ -2,9 +2,6 @@
 <selection>
  <class pattern="ROOT::Math::SMatrix<*>" />
  <class pattern="ROOT::Math::MatRepStd<*>" />
-  <class pattern="ROOT::Math::MatRepSym<*>" >
-    <field name="fOff" transient="true"/>


note for posterity: this data member was removed in 2015
root-project/root@9219906#diff-8e7303403181c06dc2d7e791c828076bL363

slava77 · 2019-01-16T19:04:14Z

+1

for #25670 81f77ec

code changes are in line with the PR description
jenkins tests pass and comparisons with the baseline show no relevant issues

cmsbuild · 2019-01-16T19:06:06Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-01-17T11:21:20Z

As the problems do not seem related with the regular IB, I will move forward with the integration of this PR for next IB

This PR should be tested with cms-sw/cmssw#25670. This enables pcm to be fully generated (Not yet fully loaded, though).

fabiocos · 2019-01-17T18:38:59Z

+1

This PR should be tested with cms-sw/cmssw#25670. This enables pcm to be fully generated (Not yet fully loaded, though).

cmsbuild added this to the CMSSW_10_5_X milestone Jan 15, 2019

cmsbuild added the future-commit label Jan 15, 2019

yamaguchi1024 mentioned this pull request Jan 15, 2019

[Do not merge] Testing genreflex to generate pcms for external libraries cms-sw/cmsdist#4634

Merged

Delete an unused class rule

81f77ec

ROOT::Math::MatRepSym<*> was defined, but was never used in selection files.

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending and removed future-commit labels Jan 15, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 15, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 15, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 15, 2019

cmsbuild added comparison-available and removed comparison-pending comparison-available tests-approved labels Jan 15, 2019

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 16, 2019

cms-sw deleted a comment from cmsbuild Jan 16, 2019

cmsbuild added comparison-available tests-approved and removed comparison-notrun tests-rejected labels Jan 16, 2019

cms-sw deleted a comment from cmsbuild Jan 16, 2019

slava77 reviewed Jan 16, 2019

View reviewed changes

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jan 16, 2019

yamaguchi1024 added a commit to yamaguchi1024/cmsdist that referenced this pull request Jan 17, 2019

[cxxmodule] Fix one genreflex error

9ab8168

This PR should be tested with cms-sw/cmssw#25670. This enables pcm to be fully generated (Not yet fully loaded, though).

yamaguchi1024 mentioned this pull request Jan 17, 2019

[cxxmodule] Fix genreflex errors cms-sw/cmsdist#4646

Merged

cmsbuild added orp-approved and removed orp-pending labels Jan 17, 2019

cmsbuild merged commit 6a7dbf7 into cms-sw:master Jan 17, 2019

yamaguchi1024 added a commit to yamaguchi1024/cmsdist that referenced this pull request Jan 18, 2019

[cxxmodule] Fix one genreflex error

a9bf064

This PR should be tested with cms-sw/cmssw#25670. This enables pcm to be fully generated (Not yet fully loaded, though).

yamaguchi1024 added a commit to yamaguchi1024/cmsdist that referenced this pull request Jan 21, 2019

[cxxmodule] Fix one genreflex error

ceafc41

This PR should be tested with cms-sw/cmssw#25670. This enables pcm to be fully generated (Not yet fully loaded, though).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete an unused class rule #25670

Delete an unused class rule #25670

yamaguchi1024 commented Jan 15, 2019

smuzaffar commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

smuzaffar commented Jan 15, 2019

cmsbuild commented Jan 15, 2019 •

edited

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

smuzaffar commented Jan 16, 2019

slava77 commented Jan 16, 2019

smuzaffar commented Jan 16, 2019

slava77 Jan 16, 2019

slava77 commented Jan 16, 2019

cmsbuild commented Jan 16, 2019

fabiocos commented Jan 17, 2019

fabiocos commented Jan 17, 2019

Delete an unused class rule #25670

Delete an unused class rule #25670

Conversation

yamaguchi1024 commented Jan 15, 2019

smuzaffar commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

smuzaffar commented Jan 15, 2019

cmsbuild commented Jan 15, 2019 • edited

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

cmsbuild commented Jan 15, 2019

smuzaffar commented Jan 16, 2019

slava77 commented Jan 16, 2019

smuzaffar commented Jan 16, 2019

slava77 Jan 16, 2019

Choose a reason for hiding this comment

slava77 commented Jan 16, 2019

cmsbuild commented Jan 16, 2019

fabiocos commented Jan 17, 2019

fabiocos commented Jan 17, 2019

cmsbuild commented Jan 15, 2019 •

edited