Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ResidualDecay port from 62X #2568

Merged
merged 1 commit into from Feb 26, 2014

Conversation

mkirsano
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mkirsano for CMSSW_7_0_X.

Fix ResidualDecay port from 62X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mkirsano
Copy link
Contributor Author

Forgotten to be ported from 6_2_X

@vciulli
Copy link
Contributor

vciulli commented Feb 23, 2014

+1

This is a bug fix.
It is not urgent, but please include it in the first patch.

On 20 Feb 2014, at 22:47, cmsbuild notifications@github.com wrote:

A new Pull Request was created by @mkirsano for CMSSW_7_0_X.

Fix ResidualDecay port from 62X

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @cmsbuild, @Degano, @bendavid, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


Reply to this email directly or view it on GitHub.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

nclopezo added a commit that referenced this pull request Feb 26, 2014
 GeneratorInterface/Pythia8Interface -- Fix ResidualDecay port from 62X
@nclopezo nclopezo merged commit 95b59e6 into cms-sw:CMSSW_7_0_X Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants