Fix the signature of SiStripTrivialClusterSource::beginRun()

[makortel]

This means that earlier the beginRun() was not called by the framework, and as a knock-on effect the produce() didn't do much useful work.

Tested in CMSSW_10_5_X_2019-01-13-0000.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25693/8063

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32681/console Started: 2019/01/17 22:47

[makortel]

I'm a bit tempted to ask whether this class is still useful (the last non-technical commit was in 2007)?

[cmsbuild]

+1
Tested at: c8887f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25693/32681/summary.html

[cmsbuild]

Comparison job queued.

[slava77]

I'm a bit tempted to ask whether this class is still useful (the last non-technical commit was in 2007)?

since we can always revert a remove, why not try it now. it's not used in production (based on git grep)

@OlivierBondu @alesaggio @pieterdavid

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25693/32681/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[pieterdavid]

Indeed, it seems to be only used for purely technical testing of SiStripFEDRawDataAnalyzer (from this config). To be honest I did not know about this class, for the latest developments we used raw files as a starting point instead.

If you think it is best to remove this I won't object, but there is more such test code in the package... I created a task on Jira to review/update that in any case (I will work on this as an EPR task in 2019).

[makortel]

@pieterdavid

If you think it is best to remove this I won't object, but there is more such test code in the package... I created a task on Jira to review/update that in any case (I will work on this as an EPR task in 2019).

Thanks for the comments. If you're going to review the contents of the test code in this package, I think it is easiest to leave this class as part of that exercise.

[perrotta]

+1

• technical
• jenkins tests pass
• (the class can be eventually removed if not needed any more: in the meanwhile better to have it fixed)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1