Allow calculation of muon ID bitset from const reference to muon

[guitargeek]

The POG recommendation for muon IDs is to use this muon ID bitset [1] for 94X and up. In my analysis framework, I would like to recompute this bitset to get all the IDs in the same way, even when the sample was older or does not have all the IDs set yet. In the current CMSSW code, you can't compute the ID bitset without setting the bitset of the muon. That's inconvenient if all you (want to) have are const references to the muons, so I made this little commit in my analysis branch.

Maybe this change can also be done in master so other analyzers might profit as well? Thanks!

[1] https://twiki.cern.ch/twiki/bin/view/CMS/SWGuideMuonIdRun2#Muon_selectors_Since_9_4_X

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25698/8069

• This PR adds an extra 48KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

DataFormats/MuonReco
PhysicsTools/PatAlgos
RecoMuon/MuonIdentification

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @abbiendi, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @JyothsnaKomaragiri, @ahinzmann, @smoortga, @acaudron, @jhgoh, @jdolen, @HuguesBrun, @drkovalskyi, @ferencek, @trocino, @rociovilar, @rovere, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @amagitte, @clelange, @echapon, @battibass, @calderona, @mverzett, @bachtis, @gpetruc, @imarches, @mariadalfonso, @pvmulder, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

This looks rather simple to me.

@drkovalskyi @folguera
please confirm there are no concerns about this from your side.
Thanks.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32686/console Started: 2019/01/18 00:26

[cmsbuild]

+1
Tested at: 646a5b1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25698/32686/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25698/32686/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[drkovalskyi]

Looks good to me.

[slava77]

+1

for #25698 646a5b1

• code changes are in line with the PR description; this is mainly a technical update
• jenkins tests pass and comparisons with the baseline show no differences

[fabiocos]

+1

[fabiocos]

merge