-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove std::move from FastSim TrackingLayer to allow better compiler optimization #25705
Remove std::move from FastSim TrackingLayer to allow better compiler optimization #25705
Conversation
Moving a temporary object was preventing the compiler from doing copy elision. This was found by clang.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25705/8089
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FastSimulation/Tracking @cmsbuild, @ssekmen, @lveldere, @mdhildreth, @civanch can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Ping |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Moving a temporary object was preventing the compiler from doing copy
elision. This was found by clang.
Tested in CMSSW_10_5_X_2019-01-13-0000, no changes expected.