Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in PixelTrackReconstruction #2571

Merged
merged 1 commit into from Feb 21, 2014

Conversation

makortel
Copy link
Contributor

Fixes the segfault reported by Giulio in https://hypernews.cern.ch/HyperNews/CMS/get/swReleases/4012.html. The problem was a spurious delete of theRegionProducer in halt() (called from PixelTrackProducer::endRun()), while it is constructed now in the PixelTrackReconstruction constructor. The bug was introduced in 4f569be (probably by mistake in rebase or something).

The theMerger_ would have suffered from the same problem, so I changed it too to std:unique_ptr.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

Fix segfault in PixelTrackReconstruction

It involves the following packages:

RecoPixelVertexing/PixelTrackFitting

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Feb 21, 2014

This is crashing right now. I'll bypass signature to have it in the IB, @slava77 @anton-a complain if not ok.

ktf added a commit that referenced this pull request Feb 21, 2014
RecoFix -- Fix segfault in PixelTrackReconstruction
@ktf ktf merged commit 94402c2 into cms-sw:CMSSW_7_1_X Feb 21, 2014
@slava77
Copy link
Contributor

slava77 commented Feb 21, 2014

Giulio, did you mean not crashing anymore?

@davidlange6
Copy link
Contributor

@slava77 - this PR fixes a crash in the recent IBs, yes.

On Feb 21, 2014, at 2:12 PM, slava77 notifications@github.com
wrote:

Giulio, did you mean not crashing anymore?


Reply to this email directly or view it on GitHub.

@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre4, CMSSW_7_1_0_pre3 Feb 24, 2014
This was referenced Mar 5, 2014
@nclopezo nclopezo modified the milestones: CMSSW_7_1_0_pre5, CMSSW_7_1_0_pre4 Mar 10, 2014
@makortel makortel deleted the fixPixelTrackReconstruction branch October 20, 2016 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants