Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed header problems in PhysicsTools/Utilities #25720

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Fixed header problems in PhysicsTools/Utilities #25720

merged 2 commits into from
Jan 22, 2019

Conversation

Dr15Jones
Copy link
Contributor

@Dr15Jones Dr15Jones commented Jan 21, 2019 •
edited

  • Boost had moved a header from /math to /integer
  • There were includes missing in SimplifyProduct.h

@Dr15Jones
Removed use of deprecated boost header in PhysicsTools/Utilities
0894fb2 
Boost had moved the header from /math to /integer
@cmsbuild cmsbuild added this to the CMSSW_10_5_X milestone Jan 21, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Use std::is_same instead of boost::is_same
84c4929 
Also added missing header to make SimplifyProduct self consistent.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones Dr15Jones changed the title Removed use of deprecated boost header in PhysicsTools/Utilities Fixed header problems in PhysicsTools/Utilities Jan 21, 2019
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25720/8111

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

PhysicsTools/Utilities

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 21, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32740/console Started: 2019/01/21 15:57
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32741/console Started: 2019/01/21 15:59

@cmsbuild
Copy link
Contributor

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@Dr15Jones
Copy link
Contributor Author

@smuzaffar this should clean up the check-headers problems we've seen.

@Dr15Jones
Copy link
Contributor Author

@smuzaffar the test failure message is very strange:

-1
Tested at: UNKNOWN
I was not able to find a release to test this PR. See the Jenkins logs for more details.

@smuzaffar
Copy link
Contributor

this should be fixed now. PR tests are running , I can delete the comment to make it less confusing

@cmsbuild
Copy link
Contributor

+1
Tested at: 84c4929
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25720/32741/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6406d33
930c41d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25720/32741/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25720/32741/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25720/32741/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 64c594d into cms-sw:master Jan 22, 2019
@Dr15Jones Dr15Jones deleted the boostPhysicsToolsCommon branch January 23, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_10_5_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @smuzaffar @fabiocos