Working Version PixelCPECluster Repair (still turned off)

[OzAmram]

This PR is meant to fully implement the new pixel CPE Cluster Repair.
We are making the changes discussed in the Dec. 14th reco meeting (slides here).

These changes include:

• Full working version of PixelCPEClusterRepair that will be run in the last fit of tracking, superceding PixelCPETemplate reco
• This new CPE defaults to the same 1D reco as before, but in special cases it will run a 2D reco that can correct for missing charge information
• The 2d reco will be activated for barrel edge-y hits and for broken clusters that have too little charge & too short length
• There is also a small bug fix for CPEBase that fixes possible incorrect setting of cluster edge flags in the case of a cluster of length 1

Our homework from that meeting was to measure the cost of these changes in CPU time and the benefits in terms of higher level observables. We have done both and attached some slides showing our results. We will be presenting these slides at the Pixel Offline Meeting on Wed. Jan 23rd.
Slides here.

We are still working on generating all the needed 2D templates for different data taking IOV's so we current expect that many of the automated tests will fail unless they run on a specific IOV's that we currently have templates for and use specific Global Tags. More IOV's will be continually added.

EDIT:
This PR still leaves CPE Cluster Repair turned off. To turn it on you only need to uncomment the two lines here

@perrotta @slava77 @fabiocos @makortel @tvami @tsusa @OzAmram @cmantill @schuetzepaul @pmaksim1

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25727/8121

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

RecoLocalTracker/SiPixelRecHits
RecoTracker/TransientTrackingRecHit

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @dkotlins, @gpetruc, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25727/8153

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #25727 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

[OzAmram]

Based on the Pixel offline meeting this morning. It was decided to keep Cluster Repair turned off in this PR.
To turn it on you just need to uncomment the two lines here

If after discussion and validation with other groups, it is determined that we want these changes in for the UL re-reco then we will submit another PR turning on CR.

I am editing the title accordingly.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32827/console Started: 2019/01/24 17:03

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25727/8201

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #25727 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

[OzAmram]

Just pushed a new commit that covers the comments in the code review. In SiPixelTemateReco2D I switched all of the fabs to std::abs and removed the un-needed fabs that was pointed out.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32872/console Started: 2019/01/29 06:50

[cmsbuild]

+1
Tested at: b534fe8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25727/32872/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
7a948bb
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25727/32872/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25727/32872/git-merge-result

[cmsbuild]

Comparison job queued.

[perrotta]

I've tried to run it by enabling the CPE cluster repair, but of course I miss the needed template.
Do you have a recipe to run it, just to verify that everything does it smoothly?

[tvami]

I've tried to run it by enabling the CPE cluster repair, but of course I miss the needed template.
Do you have a recipe to run it, just to verify that everything does it smoothly?

Please use this GT for any data run: 104X_dataRun2_pixel2DTemplate_Cand_v1

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25727/32872/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• This has been verified running smoothly, once enabled with the dedicate switch and appropriate GT
• Physics and computational performance will be re-evaluated if and when the CPE ClusterRepair will be admitted in the reco tracker chain: the attached performance report anticipates a rather limited cost in terms of CPU timing, and some possible improved quality for the reconstructed tracks
• With the default configs the ClusterRepair is not enabled and no effects are expected in the outputs, and none are seen in the results of the jenkins tests

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1