keep phase2_timing_layer functional #25745
Conversation
…r_tile and phase2_timing_layer_bar
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25745/8142
|
|
A new Pull Request was created by @bendavid (Josh Bendavid) for master. It involves the following packages: RecoParticleFlow/PFProducer @perrotta, @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test workflow 20434.0 |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 232a533 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: AddOn
I found errors in the following addon tests: cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Wed Jan 23 16:53:15 2019-date Wed Jan 23 16:48:36 2019 s - exit: 35584 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
(the failure here looks unrelated to this PR) |
|
Comparison is ready Comparison Summary:
|
|
In a private test of mine I manage to run without crashes the failing test |
|
@kpedro88 concerning you remark #25628 (comment) : that is ok with me, it would allow us to keep a common part and separate just the digitization, although it looks ultimately aesthetics. I would keep it for a separate PR though, as it needs to touch also other parts of the code |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
comparison-available
tests-rejected
tests-pending
labels
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 Minor changes to Validation config. |
|
+upgrade |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
phase2_timing_layer era when used without phase2_timing_layer_tile or phase_2_timing_layer_bar does not include mtd global reco, and therefore the downstream changes to the 4d vertex reconstruction, etc to use fullsim inputs should not be activated in this case.