Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fastsim era 2018 and workflows -- backport to 10_2_X #25754

Merged
merged 10 commits into from
Jan 30, 2019
Merged

Fastsim era 2018 and workflows -- backport to 10_2_X #25754

merged 10 commits into from
Jan 30, 2019

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Jan 23, 2019

backport of #25683

@cmsbuild cmsbuild added this to the CMSSW_10_2_X milestone Jan 23, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2019 •
edited

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_10_2_X.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences

@pgunnell, @prebello, @zhenhu, @kpedro88, @cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen
Copy link
Contributor Author

ssekmen commented Jan 23, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 23, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32802/console Started: 2019/01/23 23:11

@cmsbuild
Copy link
Contributor

+1
Tested at: cf05308
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25754/32802/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25754/32802/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 25, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32845/console Started: 2019/01/25 17:28

@cmsbuild
Copy link
Contributor

+1
Tested at: 4a628e8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25754/32845/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25754/32845/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25754/2018.1_TTbar_13_UP18+TTbarFS_13_UP18+HARVESTUP18FS+MINIAODMCUP18FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007209
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@zhenhu
Copy link
Contributor

zhenhu commented Jan 28, 2019

+1

@kpedro88
Copy link
Contributor

+upgrade

@fabiocos
Copy link
Contributor

+operations

the backport of the modifications to StandardSequences and Eras looks correct

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25754/8208

  • This PR adds an extra 60KB to repository

@fabiocos
Copy link
Contributor

+1

@ssekmen @prebello @zhenhu merging this PR will create failing workflows until input files are defined, we will need a new PR for them

@cmsbuild cmsbuild merged commit 3b23500 into cms-sw:CMSSW_10_2_X Jan 30, 2019
@zhenhu zhenhu mentioned this pull request Feb 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

@zhenhu zhenhu zhenhu left review comments

Assignees
No one assigned
Labels
backport-ok comparison-available fully-signed operations-approved orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ssekmen @cmsbuild @kpedro88 @zhenhu @fabiocos @makortel