Some GsfElectronAlgo modernization

[guitargeek]

• no raw pointers owned by GsfElectronAlgo anymore => no delete
• Having configuration classes as unique_ptr required moving their declarations to header file
• Dropping construction of GsfElectronAlgo::GeneralData as initializer list is enough
• more (const) & instead of * as function arguments
• Performance: temporary electron is moved instead of copied
• in particular, the temporary electron collection is now on the stack and not heap
• occasional const added

Local matrix tests pass. Should be quick to review as (hopefully) "idiomatic" PR.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25755/8156

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

RecoEgamma/EgammaElectronAlgos
RecoEgamma/EgammaElectronProducers

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@jainshilpi, @Sam-Harper, @varuns23, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32809/console Started: 2019/01/24 07:58

[cmsbuild]

+1
Tested at: c98d00d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25755/32809/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25755/32809/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

@guitargeek a rebase is needed
(Maybe these "technical" updates could more conveniently wait for the other work going on in parallel in EGamma having settled down)

[guitargeek]

You are right, I forgot about the H/E development which was still open. Okay I will rebase just this time and then hold on with the technical updates.

[perrotta]

@guitargeek : I have just signed #25729 which also conflict with this one. If it is merged quickly, you can rebase only once when a new IB with all them in will become available

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25755/32999/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33147/console Started: 2019/02/15 10:38

[cmsbuild]

+1
Tested at: e172bb9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25755/33147/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25755/33147/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3098286
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3098088
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Changes are mostly technical, basically a modernization and optimization of the code
• Timing is pretty similar to the one taken by the version of the code in the baseline, and there are no differences in the outputs
• Checked running also in the bParking era
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Dr15Jones]

@smuzaffar the most recent clang RelVal has build errors related to this pull request. As far as I can see, the code is fine and from the types of errors it looks like the clang build was done incorrectly such as in the wrong order or picking stuff up from the base release instead of the patch?