-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-hgx179 Extend HGCScintillatorDetId to cover both detector and trigger cells #25756
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25756/8157
|
A new Pull Request was created by @bsunanda for master. It involves the following packages: DataFormats/ForwardDetId @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25756/8158
|
The tests are being triggered in jenkins. |
Pull request #25756 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please check and sign again. |
Comparison job queued. |
The code-checks are being triggered in jenkins. |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25756/8171
|
The tests are being triggered in jenkins. |
Pull request #25756 was updated. @cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please check and sign again. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
One additional bit used to distinguish between detector and trigger cells. Accordingly several methods are used to convert one to other