Fixing the seed check in CA iterations of FastSim #25758
Conversation
|
The code-checks are being triggered in jenkins. |
|
@pmaksim1 , please watch. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25758/8163
|
|
A new Pull Request was created by @angirar for master. It involves the following packages: FastSimulation/Tracking @cmsbuild, @lveldere, @civanch, @ssekmen, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@fabiocos , for our better understanding, which exact DQM plot are you referring to? Thanks. |
|
please test workflow 2017.1 |
cmsbuild
added
comparison-pending
tests-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
@ssekmen in the short list there are 2 FS workflows run in the PR test, and according to #25758 (comment) no difference is observed in DQM output. I now see that you are checking workflow 2017.1 |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
The 2017.1 workflow test is done, but I realize that a direct comparison with the baseline cannot be automatically done. Is there a command to do this here? Otherwise we'll have to rely on @angirar 's comparison plot. |
|
@ssekmen a baseline plot should be manually produced for that based to my knowledge |
|
+1 a test was done by the author on workflows sensitive to this update, results presented in the documentation of this PR |
|
Thank you @ssekmen @fabiocos ! |
CAHitNTupletGenerator::hitNtuplets() takes in empty std::vector of type 'OrderedHitSeeds' from the SeedFinderSelector and modifies its value depending upon whether hit combination has qualified for a seed or not. The size of the std::vector is fixed to be equal to the number of tracking regions in IntermediateHitDoublets. Therefore, the size of the elements inside this container should be checked rather than the size of the vector itself to see if seed candidate has passed.
Attaching below a plot of tracking efficiency vs pT for the 'Out of the box' tracks which demonstrates the effect of this change. In the plot, red curve is current FastSim (without this fix), blue is FastSim after this fix in place and black is FullSim. As can be seen, agreement of FastSim with FullSim will become much better after this change which indicates the proper implementation of the seed check.