EventSetupRecordImpl now uses std::vectors instead of std::map #25763

Dr15Jones · 2019-01-24T23:00:26Z

The proxies and their associated keys are now stored in two synchronized std::vectors rather than a map.
This change is in anticipation of further EventSetup changes.

The proxies and their associated keys are now stored in two synchronized std::vectors rather than a map. This is in anticipation of further EventSetup changes.

cmsbuild · 2019-01-24T23:02:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-24T23:10:02Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25763/8178

This PR adds an extra 24KB to repository

cmsbuild · 2019-01-24T23:10:32Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-01-24T23:35:29Z

please test

cmsbuild · 2019-01-24T23:35:58Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32836/console Started: 2019/01/25 00:36

cmsbuild · 2019-01-25T06:45:56Z

+1
Tested at: 5e01aeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32836/summary.html
Additional comment: 'Compilation

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
409d602
8d65b05
2d77b3c
3739934
226c9db
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32836/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32836/git-merge-result

cmsbuild · 2019-01-25T06:46:00Z

Comparison job queued.

cmsbuild · 2019-01-25T10:24:19Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32836/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 148
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097095
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

Dr15Jones · 2019-01-25T12:57:25Z

+1

cmsbuild · 2019-01-26T05:33:25Z

+1
Tested at: 5e01aeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32847/summary.html
Additional comment: 'Compilation

cmsbuild · 2019-01-26T05:33:30Z

Comparison job queued.

cmsbuild · 2019-01-26T07:09:43Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32847/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097242
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2019-01-26T15:09:30Z

@Dr15Jones @smuzaffar the bot reports 3 compilation warnings for FWCore/Integration but:

the html report is unavailable at the link provided https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32847/build-logs/FWCore/Integration/log.html
in a standalone test of mine "scram b" does not show any warning for this package.

As far as I can see this PR could move forward, but I would like to better understand this report before

Dr15Jones · 2019-01-26T19:26:02Z

The FWCore/Integration warnings are most likely not from this pull request and are instead already seen in the IB, e.g.
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc700/CMSSW_10_5_X_2019-01-24-1100/FWCore/Integration

This is now fixed with #25764

fabiocos · 2019-01-27T17:30:52Z

please test

just to cross verify, I will move forward tomorrow with the integration after pre1 has been built

cmsbuild · 2019-01-27T17:31:14Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32857/console Started: 2019/01/27 19:20

cmsbuild · 2019-01-28T00:45:47Z

+1
Tested at: 5e01aeb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32857/summary.html

cmsbuild · 2019-01-28T00:45:52Z

Comparison job queued.

cmsbuild · 2019-01-28T02:01:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25763/32857/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097242
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2019-01-28T09:10:46Z

indeed the compilation warning has disappeared after the integration of #25764

fabiocos · 2019-01-28T09:38:55Z

+1

Dr15Jones added 2 commits January 24, 2019 16:37

Added operator!= to DataKey

d63585d

EventSetupRecordImpl now uses std::vectors instead of std::map

5e01aeb

The proxies and their associated keys are now stored in two synchronized std::vectors rather than a map. This is in anticipation of further EventSetup changes.

cmsbuild added this to the CMSSW_10_5_X milestone Jan 24, 2019

cmsbuild added code-checks-pending comparison-pending core-pending orp-pending pending-signatures tests-pending labels Jan 24, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 24, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 24, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 25, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 25, 2019

cmsbuild added core-approved fully-signed and removed core-pending pending-signatures labels Jan 25, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 26, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 26, 2019

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Jan 27, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 28, 2019

cmsbuild added orp-approved and removed orp-pending labels Jan 28, 2019

cmsbuild merged commit 2912090 into cms-sw:master Jan 28, 2019

Dr15Jones deleted the vectorEventSetupRecord branch January 28, 2019 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EventSetupRecordImpl now uses std::vectors instead of std::map #25763

EventSetupRecordImpl now uses std::vectors instead of std::map #25763

Dr15Jones commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

Dr15Jones commented Jan 24, 2019

cmsbuild commented Jan 24, 2019 •

edited

cmsbuild commented Jan 25, 2019

cmsbuild commented Jan 25, 2019

cmsbuild commented Jan 25, 2019

Dr15Jones commented Jan 25, 2019

cmsbuild commented Jan 26, 2019

cmsbuild commented Jan 26, 2019

cmsbuild commented Jan 26, 2019

fabiocos commented Jan 26, 2019

Dr15Jones commented Jan 26, 2019

fabiocos commented Jan 27, 2019

cmsbuild commented Jan 27, 2019 •

edited

cmsbuild commented Jan 28, 2019

cmsbuild commented Jan 28, 2019

cmsbuild commented Jan 28, 2019

fabiocos commented Jan 28, 2019

fabiocos commented Jan 28, 2019

EventSetupRecordImpl now uses std::vectors instead of std::map #25763

EventSetupRecordImpl now uses std::vectors instead of std::map #25763

Conversation

Dr15Jones commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

cmsbuild commented Jan 24, 2019

Dr15Jones commented Jan 24, 2019

cmsbuild commented Jan 24, 2019 • edited

cmsbuild commented Jan 25, 2019

cmsbuild commented Jan 25, 2019

cmsbuild commented Jan 25, 2019

Dr15Jones commented Jan 25, 2019

cmsbuild commented Jan 26, 2019

cmsbuild commented Jan 26, 2019

cmsbuild commented Jan 26, 2019

fabiocos commented Jan 26, 2019

Dr15Jones commented Jan 26, 2019

fabiocos commented Jan 27, 2019

cmsbuild commented Jan 27, 2019 • edited

cmsbuild commented Jan 28, 2019

cmsbuild commented Jan 28, 2019

cmsbuild commented Jan 28, 2019

fabiocos commented Jan 28, 2019

fabiocos commented Jan 28, 2019

cmsbuild commented Jan 24, 2019 •

edited

cmsbuild commented Jan 27, 2019 •

edited