Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lowPtGsfElectronSequence back to highlevelreco (105X) #25773

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

bainbrid
Copy link
Contributor

This PR has been made in response to this request.

While Slava suggests to remove the dependence on rho and use instead nPV or similar, we note that the BDT models used by the LowPtGsfElectronSeedProducer use rho as an input variable. So removing this dependence would mean a retraining is mandatory. Given the very tight timescales, it is very unlikely that we will be able to retrain the models in time and we expect to rely on the existing models already merged into cms-data. It may be possible for the 10_5_X cycle, but almost certainly not the 10_2_X cycle, which need for data processing ~now.

@perrotta @slava77 @mverzett @nancymarinelli

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25773/8191

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bainbrid for master.

It involves the following packages:

Configuration/StandardSequences
RecoEgamma/Configuration

@perrotta, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@varuns23, @Sam-Harper, @makortel, @felicepantaleo, @jainshilpi, @GiacomoSguazzoni, @rovere, @lgray, @Martin-Grunewald, @VinInn, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 27, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32853/console Started: 2019/01/27 09:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25773/32853/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@perrotta
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

+operations

the update of the StandardSequences appears coherent with the purpose of the PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants