Fixes to TrackInfoProducer

[makortel]

This PR

• removes unused variable (fixes a clang warning)
• fixes a memory leak by removing an unnecessary new and copy-construction

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25778/8198

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

AnalysisAlgos/TrackInfoProducer

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32869/console Started: 2019/01/28 22:07

[makortel]

I wonder if these classes are still useful (last non-technical commit is from 2007). If they are not, could we consider removing them?

[cmsbuild]

-1

Tested at: 1a342ac

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25778/32869/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following workflows:
1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[makortel]

The 1325.7 step2 segfaults in

#4  <signal handler called>
#5  0x00007f4b907b5000 in ?? ()
#6  0x00007f4be1a0172e in TFormula::DoEval(double const*, double const*) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_5_X_2019-01-28-1100/external/slc7_amd64_gcc700/lib/libHist.so
#7  0x00007f4be1a01915 in TFormula::Eval(double, double, double, double) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_5_X_2019-01-28-1100/external/slc7_amd64_gcc700/lib/libHist.so
#8  0x00007f4be19d88f4 in TF1::Eval(double, double, double, double) const () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_5_X_2019-01-28-1100/external/slc7_amd64_gcc700/lib/libHist.so
#9  0x00007f4bb8972194 in BTagCalibrationReader::BTagCalibrationReaderImpl::eval_auto_bounds(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, BTagEntry::JetFlavor, float, float, float) const () from /cvmfs/cms-ib.cern.ch/nweek-02561/slc7_amd64_gcc700/cms/cmssw/CMSSW_10_5_X_2019-01-27-0000/lib/slc7_amd64_gcc700/libCondToolsBTau.so
#10 0x00007f4bb8a9330a in BTagSFProducer::produce(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc700/cms/cmssw-patch/CMSSW_10_5_X_2019-01-28-1100/lib/slc7_amd64_gcc700/pluginPhysicsToolsNanoAODPlugins.so

I see no references to TrackInfo in either BTagCalibrationReader or BTagSFProducer.

[makortel]

@cmsbuild, please test

Let's try again.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32880/console Started: 2019/01/29 16:25

[cmsbuild]

+1
Tested at: 1a342ac
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25778/32880/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25778/32880/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1

[fabiocos]

merge