fix buffer overflow in TrackCleaner

[slava77]

this should resolve #21313
and also #25570
this is a kludge, not a full fix.

@JanFSchulte @mtosi @mandrenguyen @abaty
It looks like RecoPixelVertexing/PixelLowPtUtilities/src/TrackCleaner.cc is affecting only the HeavyIons scenario setup running on phase-1.
Please let me know if there is a task already to either purge the HeavyIons scenario workflows for post-phase-0 or to instead migrate them to a phase-1 aware pixel tracking.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25786/8219

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

RecoPixelVertexing/PixelLowPtUtilities

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32891/console Started: 2019/01/30 02:08

[cmsbuild]

+1
Tested at: 3518e67
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25786/32891/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25786/32891/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #25786 3518e67

• jenkins tests pass and comparisons with the baseline show no differences as expected
  • existing and tested phase-0 heavy ion workflows should not be affected
  • wf 150.0 is affected but it was recently removed from the default test list. I tested locally that the reproducibility is restored after the fix.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1